Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to CKAN 2.11 and master images (remove supervisor and tidy up) #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kowh-ai
Copy link
Contributor

@kowh-ai kowh-ai commented Aug 1, 2024

fixes: #59

  • remove Supervisor from CKAN 2.11 and Master images
  • remove the ContainerCanary stuff as this will be superseded by the future work in Docker Scout
  • delete who.ini lines in Dockerfile, not needed anymore as of CKAN 2.10

A change to the ckan-docker repo will accompany this update. The HEALTHCHECK will be at the Docker Compose level as this has precedence over any healthchecks at the container level

- remove the ContainerCanary stuff
- delete who.ini lines in Dockerfile - not needed anymore
-
@Markus92
Copy link

If supervisor gets removed, what would be the preferred way to run the harvester fetch/gather consumers? The official documentation of the extension still refers to those (see https://github.com/ckan/ckanext-harvest/blob/master/README.rst#setting-up-the-harvesters-on-a-production-server)

@kowh-ai
Copy link
Contributor Author

kowh-ai commented Aug 16, 2024

@Markus92 - There shouldn’t be any need to run Supervisor in a Docker Compose environment. The healthcheck feature of Docker Compose does the same thing ie: process monitoring and is flexible enough to enhance something more elaborate if thats required. We are trying to avoid superfluous libraries/software in the Docker images/containers.

The harvester documentation is for a standard (traditional) server based environment.

I’ll create a new issue to investigate this. Are you running Harvester in its own container or is it running alongside the CKAN UI in the ckan container?

@Markus92
Copy link

Markus92 commented Aug 16, 2024

@kowh-ai we're running it in the same container, set up following the manual of the harvesting extension linked above. Would we need to run separate containers? Is there any official documentation on this? We don't really care much for using the supervisor as a healthcheck, but breaking our harvesting setup would be a problem for us and require some migration path. Our internal policy is sticking as close to documented stuff as possible.

Our repo is here https://github.com/GenomicDataInfrastructure/gdi-userportal-ckan-docker (forked from ckan/ckan-docker), we deploy straight to Azure app services, so no real server as to speak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate dropping Supervisor in the CKAN image/container
3 participants